RFR: 8327045: Consolidate -fvisibility=hidden as a basic flag for all compilation

[Jorn Vernee]

On Thu, 29 Feb 2024 12:23:37 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> After we removed mapfiles, we can setup -fvisibility=hidden (and -Wl,--exclude-libs,ALL) in the most basic flags, so this applies to all compilation.
> 
> This will remove duplicate code and make the underlying assumptions of the build clearer.
> 
> Doing this will result in the same output result -- with one exception: native test libraries has not been compiled with this flag (and this caused an error for a Oracle-internal test).

WRT the change from `EXPORT` to `JNIEXPORT`, is that a required change, or stylistic?

>From a style perspective, it would be preferable not to use `JNIEXPORT`, since these functions are not JNI functions. But also, I think we would like to avoid accidental dependencies on JNI in the java/foreign tests. These are meant to be 'plain' native libraries.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18061#issuecomment-1971884135