RFR: 8325621: Improve jspawnhelper version checks [v2]

[Roger Riggs]

On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621)
>> 
>> Updates jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. Also tested manually by replacing jspawnhelper with incorrect version to confirm that check works.
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Code cleanup

make/modules/java.base/Launcher.gmk line 85:

> 83:           -DVERSION_INTERIM=$(VERSION_INTERIM) \
> 84:           -DVERSION_UPDATE=$(VERSION_UPDATE) \
> 85:           -DVERSION_PATCH=$(VERSION_PATCH), \

Using all 4 is way overkill for the problem at hand.  Just the FEATURE_VERSION is sufficient.
We all know better than to make incompatible changes in minor versions let alone update or patch version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18204#discussion_r1520364358