RFR: 8327460: Compile tests with the same visibility rules as product code
Magnus Ihse Bursie
ihse at openjdk.org
Tue Mar 12 13:59:15 UTC 2024
On Mon, 11 Mar 2024 06:57:42 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> > test/jdk/java/lang/Thread/jni/AttachCurrentThread/libImplicitAttach.c was missing an export. This had not been discovered before since that file was not compiled on Windows.
> It's a Linux/macOS specific test so it wasn't needed.
Yeah. I understand. I just wanted to give an explanation for why this particular test needed changes that were not present elsewhere (since other exported methods all were tested on Windows).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18135#issuecomment-1991712352
More information about the build-dev
mailing list