RFR: 8327701: Remove the xlc toolchain [v4]

Wed Mar 13 09:03:23 UTC 2024

On Wed, 13 Mar 2024 08:50:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Replace CC_VERSION_OUTPUT with CC_VERSION_STRING
>>  - We need CC_VERSION_OUTPUT before we can check it
>
> Seems  `HOTSPOT_TOOLCHAIN_TYPE=xlc ` and  `TARGET_COMPILER_xlc`  macros stay, is this intended ?
> (not saying this is a wrong thing to do, but I believed first that all the xlc toolchain references are replaced by clang?)

@MBaesken Yes, I discussed this in length above: https://github.com/openjdk/jdk/pull/18172#issuecomment-1985939418.

In short, changing that would mean changing behavior, and that is not something I want to do in a removal refactoring. Also, it is up to you guys to make it work correctly.

But I really believe you should address this. Let me know if you need help with the build aspects.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18172#issuecomment-1993862922