RFR: 8328074: Add jcheck whitespace checking for assembly files [v3]

Magnus Ihse Bursie ihse at openjdk.org
Wed Mar 13 11:45:33 UTC 2024


> As part of the ongoing effort to enable jcheck whitespace checking to all text files, it is now time to address assembly (.S) files. The hotspot assembly files were fixed as part of the hotspot mapfile removal, so only a single incorrect jdk library remains.
> 
> The main issue with `libjsvml` was inconsistent line starts, sometimes using tabs. I used the `expand` unix command line tool to replace these with spaces.

Magnus Ihse Bursie has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:

 - Enable jcheck whitespace checks for .S files
 - Run expand on libjsvml

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18268/files
  - new: https://git.openjdk.org/jdk/pull/18268/files/49fb1016..ce1d4c9f

Webrevs:
 - full: Webrev is not available because diff is too large
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18268&range=01-02

  Stats: 9 lines in 3 files changed: 0 ins; 1 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/18268.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18268/head:pull/18268

PR: https://git.openjdk.org/jdk/pull/18268


More information about the build-dev mailing list