RFR: 8328079: JDK-8326583 broke ccache compilation

Julian Waters jwaters at openjdk.org
Wed Mar 13 14:01:15 UTC 2024


On Wed, 13 Mar 2024 12:50:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> According to https://github.com/openjdk/jdk/pull/17986#issuecomment-1975396416, [JDK-8326583](https://bugs.openjdk.org/browse/JDK-8326583) broke ccache compilation.
> 
> The reason was that the ccache command line included `CCACHE_SLOPPINESS=pch_defines,time_macros`, and the comma was expanded wrongly, causing `time_macros ...` to look as an additional argument to `SetIfEmpty`.

Marked as reviewed by jwaters (Committer).

Looks good, sorry I couldn't do this one before you did

-------------

PR Review: https://git.openjdk.org/jdk/pull/18273#pullrequestreview-1934257071
PR Comment: https://git.openjdk.org/jdk/pull/18273#issuecomment-1994472575


More information about the build-dev mailing list