RFR: 8325621: Improve jspawnhelper version checks [v2]

Aleksey Shipilev shade at openjdk.org
Thu Mar 14 07:49:39 UTC 2024


On Tue, 12 Mar 2024 18:42:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code cleanup
>
> I'm fine with just using VERSION_FEATURE. I think it's a simple and straightforward enough simplification/approximation. If we think we need a more exact version comparison, then I think we should use one of the version strings instead of arbitrarily picking a set of version variables.

@erikj79, are you good with this version?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18204#issuecomment-1996757094


More information about the build-dev mailing list