RFR: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Mar 14 15:16:53 UTC 2024
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>
> These flag variables contain a lot of duplication.
>
> The first step towards bringing some sanity to this mess is to move the setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`.
>
> In a few places these standard flags are not set, partially or fullly. This is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific flag) to `SetupJdkLibrary/SetupJdkExecutable`.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
Fix syntax error
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18301/files
- new: https://git.openjdk.org/jdk/pull/18301/files/481ef850..4b398c32
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18301&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18301&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/18301.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18301/head:pull/18301
PR: https://git.openjdk.org/jdk/pull/18301
More information about the build-dev
mailing list