RFR: 8328146: Set LIBCXX automatically [v3]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Mar 14 23:07:39 UTC 2024
On Thu, 14 Mar 2024 15:53:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>>
>> - Merge branch 'master' into set-libcxx-automatically
>> - Fix extra space
>> - Restore $(LIBCXX) in tests since they don't use SetupJdkLibrary.
>> - 8328146: Set LIBCXX automatically
>
> make/modules/java.base/Lib.gmk line 217:
>
>> 215: LDFLAGS_aix := -brtl -bexpfull, \
>> 216: LIBS_linux := -lm -ldl, \
>> 217: LIBS_aix := -lm -ldecNumber, \
>
> This lib doesn't set LINK_TYPE. Did it add LIBCXX without needing it?
Apparently. It is a minimal library, consisting of a single, (almost) empty file. It also set `-lc` which is not needed. My guess is that this is the result of copy-paste code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18298#discussion_r1525584398
More information about the build-dev
mailing list