RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

Hamlin Li mli at openjdk.org
Fri Mar 15 11:31:08 UTC 2024


On Thu, 14 Mar 2024 12:23:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix variable name in github workflow
>
> src/jdk.incubator.vector/linux/native/libvmath/vect_math.h line 1:
> 
>> 1: /*
> 
> I'd just like to raise the question of naming. Right now the terms "vmath", "vect_math" and "vector_math" seems to be used interchangeably. I think it would be good to standardize on one name, and my suggestion is to go with the complete name -- that fits with a general theme in Java. It has the benefit that if there are many ways to abbreviate a term, there is only one way to not abbreviate it.
> 
> On the other hand, using `_` in library names is not really that common, so I'd suggest this file should be named `libvectormath/vector_math.h`. (And correspondingly for the other files.)

Thanks for the reviewing and suggestion. All Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18294#discussion_r1526144596


More information about the build-dev mailing list