RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

Hamlin Li mli at openjdk.org
Fri Mar 15 11:37:39 UTC 2024


On Thu, 14 Mar 2024 15:25:54 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > ```
> > * at build time
> >   
> >   * with/without sleef
> >   * with/without sve support
> > ```
> 
> What is the relevance of SVE support at build time? Should it matter what the build machine is?
> 
> Its important to realize that almost no one except the JDK devs builds their own JDK, and having SLEEF dependencies at build time will mean that almost no one will use it. All this work you've done will be for nothing.

I agree.
On the other hand, I see previously there was discussion about this already, and current solution got some points 
https://github.com/openjdk/jdk/pull/16234#issuecomment-1836266314, https://github.com/openjdk/jdk/pull/16234#issuecomment-1836449876

So, currently maybe we could go with this solution first, and as an incremental optimization, we could introduce a dynamic loading without dependency on the bridge furnctions in libvmath at runtime. How do you think about it?

> I'm running the tests, but I have no way to confirm that SLEEF or SVE is in use. Exactly what did you do, and how did you confirm it?

Thanks for running test.
I just turn on some log, and check the output.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-1999468059
PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-1999470911


More information about the build-dev mailing list