RFR: 8328146: Set LIBCXX automatically [v3]
Erik Joelsson
erikj at openjdk.org
Fri Mar 15 12:39:39 UTC 2024
On Thu, 14 Mar 2024 14:03:07 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE is C++. We should do this automatically in SetupJdkLibrary for C++ linking.
>>
>> I also removed the superfluous `-lc` from some places where it had been added.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into set-libcxx-automatically
> - Fix extra space
> - Restore $(LIBCXX) in tests since they don't use SetupJdkLibrary.
> - 8328146: Set LIBCXX automatically
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/18298#pullrequestreview-1938855360
More information about the build-dev
mailing list