RFR: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk [v6]

Erik Joelsson erikj at openjdk.org
Fri Mar 15 12:57:40 UTC 2024


On Fri, 15 Mar 2024 12:44:49 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
>> 
>> These flag variables contain a lot of duplication.
>> 
>> The first step towards bringing some sanity to this mess is to move the setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`.
>> 
>> In a few places these standard flags are not set, partially or fullly. This is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific flag) to `SetupJdkLibrary/SetupJdkExecutable`.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into set-cflags-automatically
>  - Restore -MT to jpackage libs
>  - Simplify C[XX]FLAGS_FILTER_OUT
>  - Fix syntax error
>  - Merge branch 'master' into set-cflags-automatically
>  - 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18301#pullrequestreview-1938889584


More information about the build-dev mailing list