RFR: 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk [v8]

Magnus Ihse Bursie ihse at openjdk.org
Fri Mar 15 13:32:21 UTC 2024


> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`.
> 
> These flag variables contain a lot of duplication.
> 
> The first step towards bringing some sanity to this mess is to move the setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`.
> 
> In a few places these standard flags are not set, partially or fullly. This is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific flag) to `SetupJdkLibrary/SetupJdkExecutable`.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  Update copyright headers

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18301/files
  - new: https://git.openjdk.org/jdk/pull/18301/files/79041f5c..2ecfc7f0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18301&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18301&range=06-07

  Stats: 18 lines in 18 files changed: 0 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/18301.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18301/head:pull/18301

PR: https://git.openjdk.org/jdk/pull/18301


More information about the build-dev mailing list