RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

Sandhya Viswanathan sviswanathan at openjdk.org
Sat Mar 16 22:18:13 UTC 2024


On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> As part of the ongoing effort to enable jcheck whitespace checking to all text files, it is now time to address assembly (.S) files. The hotspot assembly files were fixed as part of the hotspot mapfile removal, so only a single incorrect jdk library remains.
>> 
>> The main issue with `libjsvml` was inconsistent line starts, sometimes using tabs. I used the `expand` unix command line tool to replace these with spaces.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make all ALIGN/.align aligned

Looks good to me.

-------------

Marked as reviewed by sviswanathan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18268#pullrequestreview-1940824156


More information about the build-dev mailing list