RFR: 8326964: Remove Eclipse Shared Workspaces [v4]
Julian Waters
jwaters at openjdk.org
Sat Mar 16 22:21:18 UTC 2024
On Fri, 15 Mar 2024 15:44:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments in CreateWorkspace.gmk
>
> Marked as reviewed by erikj (Reviewer).
@erikj79 Sorry it seems I forgot to remove the SHARED definition from the Makefile, could I get a re-review? Thanks
@magicus Also waiting for your approval
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18046#issuecomment-2001849914
More information about the build-dev
mailing list