RFR: 8326964: Remove Eclipse Shared Workspaces [v5]

[Magnus Ihse Bursie]

On Sat, 16 Mar 2024 22:20:53 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Eclipse Shared Workspaces share the same directory as the JDK itself, which does not make much sense since there can be multiple different configurations of the JDK which Eclipse does depend on (as minimalistic as it is), and there is no one true JDK configuration, unlike what this setting suggests. This feature was created when I was much less familiar with the structure of how the JDK handles different builds, and should be removed
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove SHARED definition in Main.gmk

Except for the .gitignore part, this looks good to me.

.gitignore line 22:

> 20: /.settings/
> 21: /.project
> 22: /.classpath

`.project` is repeated so that is fine to remove, but why are you removing the other two? `.cproject` sounds like it could come from CDT.

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18046#pullrequestreview-1942337344
PR Review Comment: https://git.openjdk.org/jdk/pull/18046#discussion_r1528125183