RFR: 8328177: Move LDFLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk

Magnus Ihse Bursie ihse at openjdk.org
Mon Mar 18 11:47:27 UTC 2024


On Mon, 18 Mar 2024 09:16:12 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Similar to [JDK-8328157](https://bugs.openjdk.org/browse/JDK-8328157), we want to move the setting of LDFLAGS to LDFLAGS_JDK[LIB/EXE into SetupJdkLibrary and SetupJdkExecutable.

I have verified with COMPARE_BUILD that there is no change whatsoever in the resulting binaries, for all platforms in Oracle CI: Linux x64/aarch64, macOS x64/aarch64 and Windows x64.

Also, to be clear, my intention is to try and remove quirks and workarounds like `APPEND_LDFLAGS`; but to do that I want to focus on cleaning up one library at the time. Now I just want to lay the groundwork of having a sane API.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18343#issuecomment-2003694213
PR Comment: https://git.openjdk.org/jdk/pull/18343#issuecomment-2003696055


More information about the build-dev mailing list