RFR: 8328680: Introduce JDK_LIB, and clean up module native compilation [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Fri Mar 22 11:31:25 UTC 2024
On Fri, 22 Mar 2024 10:43:40 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix indentation
>
> make/autoconf/libraries.m4 line 174:
>
>> 172:
>> 173: JDKLIB_LIBS="$BASIC_JDKLIB_LIBS"
>> 174: JDKEXE_LIBS=""
>
> This is passed to LauncherCommon while JDKLIB_LIBS is manually passed to every individual library it's used for. Why not unify them and pass JDKLIB_LIBS to LibCommon instead? Other than that seems good
JDKLIB_LIBS will be removed when I finish up the JDK_LIBS patch. (It is currently "-ljava -ljvm" on non-Windows, so basically a shortcut for setting dependencies on some commonly used JDK libraries.)
JDKEXE_LIBS was just dead code, so I removed it "eagerly" in this patch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18430#discussion_r1535433200
More information about the build-dev
mailing list