RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v52]
Julian Waters
jwaters at openjdk.org
Mon Mar 25 06:02:06 UTC 2024
On Wed, 20 Mar 2024 06:38:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>
> - Revert Formatting in awt_Component.cpp
> - Revert Formatting in awt_Window.cpp
Thanks for the clarifications! Makes my job a lot easier. The only thing I'm uncertain about is the pData local, which I don't see much benefit in removing since the null check associated with it still has to remain for code semantics to be correct
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2017282826
More information about the build-dev
mailing list