RFR: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

Magnus Ihse Bursie ihse at openjdk.org
Mon Mar 25 17:01:25 UTC 2024


On Mon, 25 Mar 2024 15:40:45 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> When doing [JDK-8326960](https://bugs.openjdk.org/browse/JDK-8326960), I missed the case when sysroot would be restored from the cache. This would skip the configure and build steps, because it would only consult the status for create-sysroot job. This is only a problem when PR gets tested the _second_ time, the first time we would always create a sysroot. I only noticed this after merging the master into existing PRs.
> 
> This is a regression that might hide build issues on platforms, and so it should be fixed ASAP.
> 
> Additional testing:
>  - [x] GHA first run: cross-compiled builds run
>  - [x] GHA second run: cross-compiled builds run

Marked as reviewed by ihse (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18475#pullrequestreview-1958289108


More information about the build-dev mailing list