RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v61]

Magnus Ihse Bursie ihse at openjdk.org
Tue Mar 26 09:07:47 UTC 2024


On Tue, 26 Mar 2024 08:55:56 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Whitespace in awt_DnDDS.cpp
>  - Whitespace in awt_DnDDT.cpp

src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 598:

> 596:         int sz = GetLocaleInfo(LOCALE_USER_DEFAULT, LOCALE_IMEASURE, NULL, 0);
> 597:         if (sz > 0) {
> 598:           LPTSTR str = (LPTSTR) SAFE_SIZE_ARRAY_ALLOC(safe_Malloc, sizeof(TCHAR), sz);

Suggestion:

          LPTSTR str = (LPTSTR)SAFE_SIZE_ARRAY_ALLOC(safe_Malloc, sizeof(TCHAR), sz);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1538833940


More information about the build-dev mailing list