RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

Magnus Ihse Bursie ihse at openjdk.org
Tue Mar 26 16:36:48 UTC 2024


On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> Thanks
>> 
>> This is a continuation of work based on [1] by @XiaohongGong, most work was done in that pr. In this new pr, just rebased the code in [1], then added some minor changes (renaming of calling method, add libsleef as extra lib in CI cross-build on aarch64 in github workflow); I aslo tested the combination of following scenarios:
>> * at build time
>>   * with/without sleef
>>   * with/without sve support 
>> * at runtime
>>   * with/without sleef
>>   * with/without sve support 
>> 
>> [1] https://github.com/openjdk/jdk/pull/16234
>> 
>> ## Regression Test
>> * test/jdk/jdk/incubator/vector/
>> * test/hotspot/jtreg/compiler/vectorapi/
>> 
>> ## Performance Test
>> Previously, @XiaohongGong has shared the data: https://github.com/openjdk/jdk/pull/16234#issuecomment-1767727028
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix jni includes

I'm not making a decision; I'm making a suggestion. 

Also, I believe a lot more information have come to light in the discussion we have been having. For me at least, the full scope, impact and intention of this PR was not at all clear initially.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-2020932361


More information about the build-dev mailing list