RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v52]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Mar 26 20:23:44 UTC 2024
On Tue, 26 Mar 2024 08:44:31 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> Maybe as a further improvement, I can inline THROW_NULL_PDATA_IF_NOT_DESTROYED at its callsites and replace the bad NullPointerException error message with the proper null pointer name. Since Phil isn't here, what do you think?
That might be a good future code cleanup, but I suggest you refrain from doing that in this change.
> Regardless, I really hope I can get this in by Thursday.
I see that you are struggling a bit to get this done. I can probably help you fix the remaining issues, but I can't push to your PR. So either I'd need to create a fork of your `patch-10` branch in my personal fork and you'll have to pull from there into your branch, or you need to give me write permissions to your personal fork. I believe you can assign permissions on a per-branch basis.
I'd really like to see this PR to come to conclusion.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2021391154
More information about the build-dev
mailing list