RFR: JDK-8324774: Add DejaVu web fonts [v2]
Jonathan Gibbons
jjg at openjdk.org
Wed Mar 27 00:46:38 UTC 2024
On Wed, 20 Mar 2024 15:54:12 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> This change adds the DejaVu web fonts that were previously maintained externally to the open repository so they are available both in JDK API documentation and any API documentation generated with the `javadoc` tool. All files added in this PR are the same as the ones previously maintained externally, with the exception of added license and name/version comments in `dejavu.css`.
>>
>> Copying of font files to the generated documentation is done by looking for font file names in `dejavu.css`, so font file names can be changed without changing the code. However, the font file list is hard-coded in `APITest.java`. `CheckLibraryVersions.java` is updated to make sure the name and version in the legal file matches the one in the stylesheet. Of course I also performed manual tests to make sure the font and legal files are copied to the output tree and used correctly in browsers.
>>
>> Once #17411 is integrated, `dejavu.css` should also be added to the list of files checked by the new "pass-through" test.
>
> Hannes Wallnöfer has updated the pull request incrementally with two additional commits since the last revision:
>
> - JDK-8327385: Add JavaDoc option to exclude web fonts from generated documentation
> - Merge try-with-resource statements
Marked as reviewed by jjg (Reviewer).
I like the new stuff for `JavadocTester` wrapped up in this work.
-------------
PR Review: https://git.openjdk.org/jdk/pull/17633#pullrequestreview-1962024918
PR Comment: https://git.openjdk.org/jdk/pull/17633#issuecomment-2021719299
More information about the build-dev
mailing list