RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

Hamlin Li mli at openjdk.org
Wed Mar 27 16:03:28 UTC 2024


On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch?
>> Thanks
>> 
>> This is a continuation of work based on [1] by @XiaohongGong, most work was done in that pr. In this new pr, just rebased the code in [1], then added some minor changes (renaming of calling method, add libsleef as extra lib in CI cross-build on aarch64 in github workflow); I aslo tested the combination of following scenarios:
>> * at build time
>>   * with/without sleef
>>   * with/without sve support 
>> * at runtime
>>   * with/without sleef
>>   * with/without sve support 
>> 
>> [1] https://github.com/openjdk/jdk/pull/16234
>> 
>> ## Regression Test
>> * test/jdk/jdk/incubator/vector/
>> * test/hotspot/jtreg/compiler/vectorapi/
>> 
>> ## Performance Test
>> Previously, @XiaohongGong has shared the data: https://github.com/openjdk/jdk/pull/16234#issuecomment-1767727028
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix jni includes

Hello @PaulSandoz,
For various reasons, [previous pr](https://github.com/openjdk/jdk/pull/16234) and current pr are thought not good enough, so I did some exploration of [integrating sleef source into jdk](https://github.com/openjdk/jdk/pull/18294#issuecomment-2018839778), the solution itself is simple and maintainace is easy.

I saw in the previous discussion, you had some [comments about integrate sleef source into jdk](https://github.com/openjdk/jdk/pull/16234#issuecomment-1821885433).

I'm not sure if you're avaialbe to take a look and continue the discussion and share your opinions? If positive, we can start from [here](https://github.com/openjdk/jdk/pull/18294#issuecomment-2020986186).

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18294#issuecomment-2023136169


More information about the build-dev mailing list