RFR: 8329178: Clean up jdk.accessibility native compilation [v2]

Phil Race prr at openjdk.org
Wed Mar 27 22:22:39 UTC 2024


On Wed, 27 Mar 2024 19:34:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/modules/jdk.accessibility/Launcher.gmk line 30:
>> 
>>> 28: ifeq ($(call isTargetOs, windows), true)
>>> 29:   ACCESSIBILITY_SRCDIR := $(TOPDIR)/src/jdk.accessibility/windows/native
>>> 30: 
>> 
>> It looks like you determined that these aren't all needed in most cases ? Since I don't see them being passed to the various builds any more. jabswitch I'm sure won't need these but I'm a bit more surprised by the others ..
>
> We don't need to explicitly set those flags. In for example SetupInspector below, we add `common` and `toolscommon` to EXTRA_SRC, which will implicitly be added to include path, and `include/bridge` is added to EXTRA_HEADER_DIRS, so all of these are accounted for.

OK, so EXTRA_SRC implies HEADER search. That's what I needed to know.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18510#discussion_r1542108864


More information about the build-dev mailing list