RFR: 8329289: Unify SetupJdkExecutable and SetupJdkLibrary

Magnus Ihse Bursie ihse at openjdk.org
Thu Mar 28 18:06:31 UTC 2024


On Thu, 28 Mar 2024 17:59:10 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Currently a lot of code is duplicated between SetupJdkExecutable and SetupJdkLibrary. Furthermore, some functionality is still missing from SetupJdkExecutable that is present in SetupJdkLibrary. These functions also have not had their documentation properly updated as they have evolved. This PR will fix all of this.

Using COMPARE_BUILD, there is no changes to any executables or production libraries. 

However, for some reason the gtest libjvm.so is 8 bytes larger on linux-x64. I can't really tell what causes this. It might be a problem with reproducible builds, or perhaps that some command line arguments has been reordered. I don't think it matters.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18537#issuecomment-2025812957


More information about the build-dev mailing list