RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes [v2]

Jan Lahoda jlahoda at openjdk.org
Thu May 2 14:24:08 UTC 2024


On Thu, 2 May 2024 07:03:20 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removing unnecessary directory cleanup.
>
> test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestImpl.java line 1104:
> 
>> 1102:         CreateSymbols.EXTENSION = ".class";
>> 1103: 
>> 1104:         deleteRecursively(ctSym);
> 
> Is double deletion needed for some kind of race condition safety?

I don't think this is needed. Thanks for noticing, removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19031#discussion_r1587724055


More information about the build-dev mailing list