RFR: 8329816: Add SLEEF version 3.6
Hamlin Li
mli at openjdk.org
Mon May 13 07:15:08 UTC 2024
On Fri, 10 May 2024 22:32:29 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to optimize vector math operations by leveraging the SLEEF library. For legal reasons the actual contribution of the SLEEF files needs to be handled separately. This enhancement adds the relevant files, enabling the rest of [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward.
Thanks for working on this.
Just one question, currently in `sleefinline_{advsimd,sve}.h` there is `#define SLEEF_ALWAYS_INLINE inline`, but what expected is something like `#define SLEEF_ALWAYS_INLINE inline __attribute__((always_inline))` (please check https://github.com/shibatch/sleef/pull/537 for details). In the future, when we change it, do we need to go through the legal process again? I guess we don't need it, but just double check it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2106818228
More information about the build-dev
mailing list