RFR: 8329816: Add SLEEF version 3.6
Hamlin Li
mli at openjdk.org
Mon May 13 21:01:08 UTC 2024
On Mon, 13 May 2024 17:33:20 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
> Looks like that change is not yet in a released version of SLEEF, and in particular not in 3.6.
>
> We do need updated approvals when we pick up new versions. Since we've gone through the process once it's typically easier/faster to do so. It will be technically easier/faster as well, now that I know how to do it and have encoded it in the createSleef.sh script.
Thanks, I see.
As the version 3.6 will introduce some performance regression compared to non-intrinsic version, so to bring the fix into jdk, we need either do a manual change (like https://github.com/openjdk/jdk/pull/18605/commits/cd70f5a970514938d05f7a2426b15f78245236d3), or wait the next version after 3.6 (which should include changes in https://github.com/shibatch/sleef/pull/537), I think we prefer the latter (i.e. depends on next version after 3.6)
That means https://github.com/openjdk/jdk/pull/18605 (JDK-8312425) requires sleef version next to 3.6 (could be 3.6.1 or 3.7).
I'm OK to push this pr first, if it's also convenient for you, as we will need to push the change between 3.6.1/3.7 and 3.6 again when 3.6.1/3.7 is released.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2108788721
More information about the build-dev
mailing list