RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v26]
Severin Gehwolf
sgehwolf at openjdk.org
Wed May 15 09:50:35 UTC 2024
On Wed, 8 May 2024 22:36:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 105 commits:
>>
>> - Generate the runtime image link diff at jlink time
>>
>> But only do that once the plugin-pipeline has run. The generation is
>> enabled with the hidden option '--generate-linkable-runtime' and
>> the resource pools available at jlink time are being used to generate
>> the diff.
>> - Merge branch 'master' into jdk-8311302-jmodless-link
>> - Use shorter name for the build tool
>> - Review feedback from Erik J.
>> - Remove dependency on CDS which isn't needed anymore
>> - Fix coment
>> - Fix comment
>> - Fix typo
>> - Revert some now unneded build changes
>> - Follow build tools naming convention
>> - ... and 95 more: https://git.openjdk.org/jdk/compare/23a72a1f...67aea4ca
>
> make/Images.gmk line 100:
>
>> 98:
>> 99: ifeq ($(JLINK_PRODUCE_RUNTIME_LINK_JDK), true)
>> 100: JLINK_JDK_EXTRA_OPTS := $(JLINK_JDK_EXTRA_OPTS) --generate-linkable-runtime
>
> I just noticed this slight improvement:
>
> Suggestion:
>
> JLINK_JDK_EXTRA_OPTS += --generate-linkable-runtime
Thanks, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1601322116
More information about the build-dev
mailing list