RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v69]
Jonathan Gibbons
jjg at openjdk.org
Thu May 16 18:29:18 UTC 2024
On Thu, 16 May 2024 16:44:51 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update tests for dangling doc comments, per review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java line 1465:
>
>> 1463: private final HtmlRenderer renderer = HtmlRenderer.builder()
>> 1464: .nodeRendererFactory(headingRendererFactory)
>> 1465: .extensions(List.of(tablesExtn/*, headingIdsExtn*/))
>
> Is there a reason to keep the commented argument?
no, it should go; thanks for catching
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1603864642
More information about the build-dev
mailing list