RFR: 8330542: Add jaxp-strict.properties in preparation for a secure by default configuration [v8]
Erik Joelsson
erikj at openjdk.org
Fri May 17 13:15:05 UTC 2024
On Fri, 17 May 2024 05:51:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove jaxp-compat.properties from the list
>
> make/modules/java.xml/Copy.gmk line 37:
>
>> 35: JAXPPROPFILE_TARGET_FILES := $(subst $(JAXPPROPFILE_SRC_DIR),$(CONF_DST_DIR),$(JAXPPROPFILE_SRCS))
>> 36:
>> 37: $(CONF_DST_DIR)/%: $(JAXPPROPFILE_SRC_DIR)/%
>
> The make file changes to copy the properties files look okay but I'm curious about why the naming changes from "XML" to "JAXPPROFILE".
If we are changing this file, we should modernize it.
$(eval $(call SetupCopyFiles, COPY_XML_MODULE_CONF, \
DEST := $(CONF_DST_DIR), \
FILES := $(wildcard $(TOPDIR)/src/java.xml/share/conf/jaxp*.properties*), \
))
TARGETS += $(COPY_XML_MODULE_CONF)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18831#discussion_r1604981949
More information about the build-dev
mailing list