RFR: 8332545: Fix handling of HTML5 entities in Markdown comments

Erik Joelsson erikj at openjdk.org
Mon May 20 23:24:01 UTC 2024


On Mon, 20 May 2024 20:17:10 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to address a crash when handling HTML5 entities in a Markdown doc comment.
> 
> The path for the `entities.txt` (originally `entities.properties`) was not correctly imported when importing the latest version of `commonmark-java`. And, the makefiles need to be updated to include the `.txt` file in the image. (The interim module for the interim javadoc already had this fix.)
> 
> A simple new test is provided, containing entities that previously caused `javadoc` to crash.

Build change looks good.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19317#pullrequestreview-2067198212


More information about the build-dev mailing list