RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v25]

Wed May 22 08:11:14 UTC 2024

On Wed, 22 May 2024 07:44:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> ... still missing...
>
> Actually, this is a bit strange. I thought jcheck would look for missing newline at EOF, and that properties files were included in the check nowadays. I'll need to check this out.

I did some testing and it turns out that this is indeed not checked. I believe this is a miss in the Skara reimplementation of jcheck. I've opened https://bugs.openjdk.org/browse/SKARA-2265 to track this.

Nevertheless, it would be good if you could fix this. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1609491669