RFR: 8330542: Add jaxp-strict.properties in preparation for a stricter default configuration [v12]

Magnus Ihse Bursie ihse at openjdk.org
Wed May 22 08:55:05 UTC 2024


On Tue, 21 May 2024 20:28:37 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Add two sample configuration files:
>> 
>>   jaxp-strict.properties: used to set strict configuration, stricter than jaxp.properties in previous versions such as JDK 22
>> 
>>>   jaxp-compat.properties: used to regain compatibility from any more restricted configuration than previous versions such as JDK 22
>> 
>> Updated on 5/16/2024
>> 
>> Design change:
>> The design is changed to include in the JDK two configuration files that are the default jaxp.properties and jaxp-strict.properties, instead of three, dropping jaxp-compat.properties.
>> 
>> Updated on 5/18/2024
>> 
>> Withdraw changes to jaxp.properties. The original idea was to match jaxp-strict.properties with regard to the properties. However, that change impact the configuration process, resulting in tests that verify the process to fail.
>
> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add a note to module-info

make/modules/java.xml/Copy.gmk line 35:

> 33: $(eval $(call SetupCopyFiles, COPY_XML_MODULE_CONF, \
> 34:     DEST := $(CONF_DST_DIR), \
> 35:     FILES := $(wildcard $(TOPDIR)/src/java.xml/share/conf/jaxp*.properties*), \

I don't think you need, nor should have, the asterisk after the extension. You are only copying `.properties` files.

Suggestion:

    FILES := $(wildcard $(TOPDIR)/src/java.xml/share/conf/jaxp*.properties), \

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18831#discussion_r1609565653


More information about the build-dev mailing list