RFR: 8331921: Hotspot assembler files should use common logic to setup exported functions [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu May 23 17:27:02 UTC 2024
On Thu, 23 May 2024 16:33:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> As seen in [JDK-8331541](https://bugs.openjdk.org/browse/JDK-8331541), if we are not consistently setting all assembler directives correctly, we can get errors that are not detected by the linker.
>>
>> We should stop duplicating this code and create a unified macro to properly setup functions, and use it everywhere.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - Merge branch 'master' into hotspot-assembler-functions
> - Fix copyright headers
> - Fix building on macos/aarch64
> - Use % instead of @ due to arm assembler
> - 8331921: Hotspot assembler files should use common logic to setup exported functions
This looks like a very nice cleanup.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19138#pullrequestreview-2074610785
More information about the build-dev
mailing list