RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v2]

[Ioi Lam]

On Thu, 23 May 2024 20:28:49 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8293980-resolve-fields-at-dumptime
>>  - 8293980: Resolve CONSTANT_FieldRef at CDS dump time
>
> src/hotspot/share/oops/constantPool.cpp line 301:
> 
>> 299:   objArrayOop rr = resolved_references();
>> 300:   if (rr != nullptr) {
>> 301:     ConstantPool* orig_pool = ArchiveBuilder::current()->get_source_addr(this);
> 
> Are the changes below necessary? I think the original was fine but I may be missing the point of this change.

It's just for consistency. "source" is the terminology used in the comments in archiveBuilder.cpp.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19355#discussion_r1612386810