RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]

Vladimir Kozlov kvn at openjdk.org
Fri Nov 1 18:04:44 UTC 2024


On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>> 
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
>  - Remove windows-32-bit code in CompilerConfig::ergo_initialize

1. There is use of `WIN32` instead of `_WIN32`.
2. There are comments referencing `Win32` which we need to rename to `Windows` to avoid confusion.
3. There is `class os::win32` in `os_windows.hpp` which is batter to rename to avoid confusion. Could be done in separate RFE.
4. "Note that, oddly enough, _WIN32 is still defined on 64-bit Windows". If it is really true, I would still suggest to use our variable `_WINDOWS` for that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2452335968


More information about the build-dev mailing list