RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]
David Holmes
dholmes at openjdk.org
Mon Nov 4 02:37:40 UTC 2024
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port. This port was [deprecated for removal in JDK 21](https://openjdk.org/jeps/449) with the express intent to remove it in a future release.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove superfluous check for 64-bit on Windows in MacroAssembler::call_clobbered_xmm_registers
> - Remove windows-32-bit code in CompilerConfig::ergo_initialize
Changes requested by dholmes (Reviewer).
src/hotspot/share/adlc/adlc.hpp line 43:
> 41:
> 42: /* Make sure that we have the intptr_t and uintptr_t definitions */
> 43: #ifdef _WIN32
As this is a synonym for `_WINDOWS` it is not obvious this deletion is correct.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21744#pullrequestreview-2412031267
PR Review Comment: https://git.openjdk.org/jdk/pull/21744#discussion_r1827135809
More information about the build-dev
mailing list