RFR: 8339480: Build static-jdk image with a statically linked launcher [v9]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Nov 4 15:45:35 UTC 2024
On Sun, 3 Nov 2024 20:23:32 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge branch 'master' into static-jdk-image
>> - Fix bug in filtering out -Wl,--exclude-libs,ALL
>> - Don't hardcode server variant
>> - Setup LDFLAGS_STATIC_JDK
>> - Update GetJREPath comment and remove unnecessary JLI_IsStaticallyLinked check
>> - Add lookup asserts
>> - Remove superfluous SRC.
>> - Merge branch 'master' into static-jdk-image
>> - Makefile changes needed for static-launcher and static-jdk-image targets
>> - Incorporate changes from leyden/hermetic-java-runtime that allows running a static launcher
>
> https://github.com/openjdk/jdk/pull/21861 for adding DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries.
@jianglizhou I'm trying to follow your comments here... Am I correct in understanding that you are saying that the missing DEF_STATIC_JNI_OnLoad is not, in fact, the problem that causes .java files to not load? Because I tried applying your patch from #21861, and it did not help.
> I think we would need to decide what is the `dll_dir` with the static JDK support and hermetic support.
Do you mean that this the core issue related to the .java launching failure?
I also find it curious that it does work on macOS, but not on Linux. This indicates, to me, that there is some difference in platform-dependent code that is different between Linux and mac, and there is not much such code in this PR. So maybe it is some pre-existing difference in code that provokes this difference in behavior.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2455046552
More information about the build-dev
mailing list