RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Nov 4 17:31:00 UTC 2024
On Mon, 4 Nov 2024 17:16:49 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>>> > With that said, it is sure as heck confusing! Which also apparently Microsoft acknowledges by phasing in the term "Windows API". So I agree that we should try to rename everything currently called "win32" into "windows". But I'd rather see such a global rename refactoring, that will also affect the 64-bit Windows platforms, to be done as a separate, follow-up PR. Are you okay with that?
>>>
>>> Yes, I completely agree to do such clean up in separate RFE. Please, file one.
>>
>> Good. I filed https://bugs.openjdk.org/browse/JDK-8343553.
>
> @magicus
> Back to my question about https://github.com/openjdk/jdk/blob/master/make/autoconf/flags-cflags.m4#L470 ?
>
> I see only few uses of `#ifdef WIN32` in HotSpot which can be replaced with `#ifdef _WINDOWS`:
>
> src/hotspot/share/runtime/sharedRuntimeTrans.cpp:#ifdef WIN32
> src/hotspot/share/runtime/sharedRuntimeTrans.cpp:#ifdef WIN32
>
>
> Note, there are a lot more usages of `WIN32` in JDK libraries native code which we may consider renaming later.
@vnkozlov I have now looked at all ~1800 case-independent hits of "win32" in the `src` directory. All of them is referring to the general Windows API, and not any 32-bit specific code, as far as I can tell from the filename and local context.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2455296938
More information about the build-dev
mailing list