RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]
Severin Gehwolf
sgehwolf at openjdk.org
Thu Nov 7 13:27:45 UTC 2024
On Tue, 5 Nov 2024 17:02:24 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> test/jtreg-ext/requires/VMProps.java line 743:
>>
>>> 741: // jdk.jlink module has the following resource indicating a runtime-linkable
>>> 742: // image. It's the diff file for runtime linking of the java.base module.
>>> 743: String linkableRuntimeResource = "jdk/tools/jlink/internal/runtimelink/diff_java.base";
>>
>> Can this access `LinkableRuntimeImage::DIFF_PATTERN` via qualified exports?
>
> I don't see how, but I may be missing something. `VMProps` isn't in any named module is it? Is it worth sprinkling `jdk.jlink`'s `module-info.java` classes with those exports for test-only purposes, though? Is there precedent that I can look at?
>
> It appears this hard-coded resource seems the lesser of the two evils to me. Thoughts?
With the latest changes there is no `VMProps` extension to determine a run-time image link capable JDK anymore. So this is gone.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1832668508
More information about the build-dev
mailing list