RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]
Phil Race
prr at openjdk.org
Fri Nov 8 21:05:42 UTC 2024
On Fri, 1 Nov 2024 18:06:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
> > I'd not looked at this test before but when I do the thing I noticed is that createPrivateValue is no longer used. But I don't see a problem with keeping the rest of the test.
>
> @prrace Do I understand correctly that _“`createPrivateValue` is no longer used”_ means `MultiUIDefaults` is never used with `ProxyLazyValue`?
>
> The [`MultiUIDefaults` class](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/MultiUIDefaults.java) is used in `UIManager`:
>
> https://github.com/openjdk/jdk/blob/c82ad845e101bf5d97c0744377d68002907d4a0e/src/java.desktop/share/classes/javax/swing/UIManager.java#L198
I think I was just saying there appeared to be dead code in the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1835053637
More information about the build-dev
mailing list