RFR: 8343883: Cannot resolve user specified toolchain-path for lld after JDK-8338304

[SendaoYan]

On Tue, 12 Nov 2024 15:00:19 GMT, SendaoYan <syan at openjdk.org> wrote:

>> make/autoconf/flags-ldflags.m4 line 78:
>> 
>>> 76:       if test "x$CXX_IS_USER_SUPPLIED" = xfalse && test "x$CC_IS_USER_SUPPLIED" = xfalse; then
>>> 77:         if test "x$TOOLCHAIN_PATH" != x; then
>>> 78:           UTIL_REQUIRE_PROGS(LLD, lld, $TOOLCHAIN_PATH)
>> 
>> No, this is not correct. Did you test this patch *without* having lld in the toolchain path? Doing this will remove the normal lookup in `$PATH` and only look in `$TOOLCHAIN_PATH`.
>
> After I remove the lld binary from `$TOOLCHAIN_PATH`, such as `mv /home/yansendao/software/acc/x86_64/bin/lld /tmp/`, the configure command generate `configure: error: Could not find required tool for LLD` as expected.

The line 77 condition statement in this PR has make sure that, if the configure command doesn't received option `--with-toolchain-path`, the normal lookup in `$PATH` still work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21999#discussion_r1838271101