RFR: 8343883: Cannot resolve user specified toolchain-path for lld after JDK-8338304 [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Nov 12 15:38:41 UTC 2024
On Tue, 12 Nov 2024 15:33:49 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>> After [JDK-8338304](https://bugs.openjdk.org/browse/JDK-8338304), below configure command will generate failure `error: Could not find required tool for LLD`. The lld linker located in path which config with option `--with-toolchain-path`, but the check `UTIL_REQUIRE_PROGS(LLD, lld)` introduced by [JDK-8338304](https://bugs.openjdk.org/browse/JDK-8338304) was unable to find the lld. This PR add the condition to deal with user specidied `--with-toolchain-path` to find the correct lld fullpath. The change has beeen verified locally, trivial fix, the risk is low.
>>
>>
>> bash configure --with-jobs=128 --with-debug-level=release --enable-unlimited-crypto --with-jvm-variants=server --with-version-opt=f4008968 --with-zlib=system --with-toolchain-type=clang --with-toolchain-path=/home/yansendao/software/acc/x86_64/bin
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> lookup $TOOLCHAIN_PATH:$PATH
This looks better, thanks.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21999#pullrequestreview-2429948246
More information about the build-dev
mailing list