RFR: 8343883: Cannot resolve user specified toolchain-path for lld after JDK-8338304 [v2]

[SendaoYan]

On Tue, 12 Nov 2024 13:28:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   lookup $TOOLCHAIN_PATH:$PATH
>
> make/autoconf/flags-ldflags.m4 line 78:
> 
>> 76:       if test "x$CXX_IS_USER_SUPPLIED" = xfalse && test "x$CC_IS_USER_SUPPLIED" = xfalse; then
>> 77:         if test "x$TOOLCHAIN_PATH" != x; then
>> 78:           UTIL_REQUIRE_PROGS(LLD, lld, $TOOLCHAIN_PATH)
> 
> Instead, keep this somewhat hacky workaround, but make it function properly by doing this:
> 
> Suggestion:
> 
>           UTIL_REQUIRE_PROGS(LLD, lld, $TOOLCHAIN_PATH:$PATH)

This solution looks for more concise, and seems equivalent to my previous solution if the statement `UTIL_REQUIRE_PROGS(LLD, lld)` lookup in `$PATH`. Thanks for your advice, the code has been changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21999#discussion_r1838302548