RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Nov 13 17:28:53 UTC 2024
On Wed, 13 Nov 2024 15:39:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> WIP, as the JEP is still not targeted. We can review code meanwhile.
>>
>> Additional testing:
>> - [x] Linux x86-32 build configure fails by default
>> - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes`
>> - [ ] GHA
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8344093-x86-32-deprecation
> - Initial work
It looks okay. Doing the deprecation is the easy part. :)
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22062#pullrequestreview-2433967298
More information about the build-dev
mailing list