RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives
Ioi Lam
iklam at openjdk.org
Wed Nov 13 19:47:28 UTC 2024
On Tue, 12 Nov 2024 23:27:27 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
> With this change, the compact object headers related CDS archives (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by default. If the user needs them, the user can specify the `--enable-cds-archive-coh=yes` build configure option.
> This change also modified the TestDefaultArchiveLoading.java test.
>
> Testing:
>
> - default build config: classes*coh.jsa CDS archives are not generated
> - build configured with `--enable-cds-archive-coh=yes`: classes*coh.jsa CDS archives are generated
> - build configured with `--enable-cds-archive-coh=no`: classes*coh.jsa CDS archives are not generated
> - passed tiers 1 and 3 tests
I think it's best to avoid modifying the test JVM. It could be used in parallel by another jtreg process, and it could also be in a read-only directory.
I would suggest checking for the existence of the COH files, and skip the test cases accordingly.
-------------
Changes requested by iklam (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22051#pullrequestreview-2434260372
More information about the build-dev
mailing list